From 10ec3a3a37f95974eeb27063f53e94e2223b7763 Mon Sep 17 00:00:00 2001 From: Ohad Livne Date: Sat, 13 Sep 2025 17:18:00 +0300 Subject: [PATCH] Handle entries with no image download link (e.g. videos) --- .local/bin/get-nasa-apod | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.local/bin/get-nasa-apod b/.local/bin/get-nasa-apod index c873456..6ca8445 100755 --- a/.local/bin/get-nasa-apod +++ b/.local/bin/get-nasa-apod @@ -19,11 +19,17 @@ echo "Received response from API" # shellcheck disable=SC2005 echo "$(printf '%s' "${response}" | jq '.')" echo "Parsing data" -picture_date="$(printf '%s' "${response}" | jq --raw-output .date)" -picture_url="$(printf '%s' "${response}" | jq --raw-output .hdurl)" rate_remaining="$(printf '%s' "${response}" | jq '."rate-limit"')" echo "Remaining requests until rate limit: ${rate_remaining}" +if [ "$(printf '%s' "${response}" | jq 'has("hdurl")')" == "false" ]; then + echo "Response contains no download URL" + exit 1 +fi + +picture_date="$(printf '%s' "${response}" | jq --raw-output .date)" +picture_url="$(printf '%s' "${response}" | jq --raw-output .hdurl)" + echo "Generating output filename" extension="${picture_url##*.}" filename="${picture_date}.${extension}"